RDMA/hns: Fix a wrong judgment of return value
authorWeihang Li <liweihang@huawei.com>
Fri, 20 Mar 2020 03:23:34 +0000 (11:23 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 26 Mar 2020 19:52:27 +0000 (16:52 -0300)
hns_roce_alloc_mtt_range() never return -1, ret should be checked
whether it is zero instead of -1.

Fixes: 1ceb0b11a8a2 ("RDMA/hns: Fix non-standard error codes")
Link: https://lore.kernel.org/r/1584674622-52773-3-git-send-email-liweihang@huawei.com
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_mr.c

index b9898e7..176f346 100644 (file)
@@ -243,7 +243,7 @@ int hns_roce_mtt_init(struct hns_roce_dev *hr_dev, int npages, int page_shift,
        /* Allocate MTT entry */
        ret = hns_roce_alloc_mtt_range(hr_dev, mtt->order, &mtt->first_seg,
                                       mtt->mtt_type);
-       if (ret == -1)
+       if (ret)
                return -ENOMEM;
 
        return 0;