show referencing node in 'file missing' message

diff --git a/build.cc b/build.cc
index 919e4ac3f2d30f72221d1d1ca2258d8c82e698d3..6282b5f26b5e201d24777eb28cd269b64c5597a2 100644 (file)
--- a/build.cc
+++ b/build.cc
@@ -14,7 +14,10 @@ bool Plan::AddSubTarget(Node* node, vector<Node*>* stack, string* err) {
   Edge* edge = node->in_edge_;
   if (!edge) {  // Leaf node.
     if (node->dirty_) {
-      *err = "'" + node->file_->path_ + "' missing "
+      string referenced;
+      if (!stack->empty())
+        referenced = ", needed by '" + stack->back()->file_->path_ + "',";
+      *err = "'" + node->file_->path_ + "'" + referenced + " missing "
              "and no known rule to make it";
     }
     return false;

diff --git a/build_test.cc b/build_test.cc
index 26d10801673f2b5432e5872779da79729465b166..81f2fbe094fb1f4a0bee37decc2b5aca5602c66d 100644 (file)
--- a/build_test.cc
+++ b/build_test.cc
@@ -350,7 +350,8 @@ TEST_F(BuildTest, MissingInput) {
   string err;
   Dirty("in1");
   EXPECT_FALSE(builder_.AddTarget("cat1", &err));
-  EXPECT_EQ("'in1' missing and no known rule to make it", err);
+  EXPECT_EQ("'in1', needed by 'cat1', missing and no known rule to make it",
+            err);
 }
 
 TEST_F(BuildTest, MissingTarget) {