[ScriptInterpreterPython] Remove buggy code to save/restore stdin.
authorDavide Italiano <ditaliano@apple.com>
Tue, 7 Apr 2020 19:41:31 +0000 (12:41 -0700)
committerDavide Italiano <ditaliano@apple.com>
Tue, 7 Apr 2020 19:43:25 +0000 (12:43 -0700)
Discussed on lldb-dev with Pavel Labath. This doesn't work for
background processes [causes Python to be stuck forever], and it's
unclear whether it's needed. There's no test, also. If this turns
out to be useful, it can be recommitted with a functional implementation
and a test.

lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

index ee94a18..c53b3bd 100644 (file)
@@ -224,10 +224,6 @@ struct InitializePythonRAII {
 public:
   InitializePythonRAII()
       : m_gil_state(PyGILState_UNLOCKED), m_was_already_initialized(false) {
-    // Python will muck with STDIN terminal state, so save off any current TTY
-    // settings so we can restore them.
-    m_stdin_tty_state.Save(STDIN_FILENO, false);
-
     InitializePythonHome();
 
 #ifdef LLDB_USE_LIBEDIT_READLINE_COMPAT_MODULE
@@ -271,8 +267,6 @@ public:
       // We initialized the threads in this function, just unlock the GIL.
       PyEval_SaveThread();
     }
-
-    m_stdin_tty_state.Restore();
   }
 
 private: