core/bufferpool.hpp: let msvc accept a non virtual protected destructor
authorPascal Thomet <pthomet@ivsweb.com>
Fri, 7 Jul 2017 19:04:12 +0000 (21:04 +0200)
committerPascal Thomet <pthomet@ivsweb.com>
Sat, 8 Jul 2017 14:15:26 +0000 (16:15 +0200)
BufferPoolController has a non virtual protected destructor (which is legitimate)

However, Visual Studio sees this as a bug, if you enable more warnings, like below
```
add_compile_options(/W3)     # level 3 warnings
add_compile_options(/we4265) # warning about missing virtual destructors
```

This is a proposition in order to silence this warning.

See https://github.com/ivsgroup/boost_warnings_minimal_demo for a demo of the same problem
with boost/exception.hpp

modules/core/include/opencv2/core/bufferpool.hpp

index 9e7b7c2..4698e5d 100644 (file)
@@ -7,6 +7,11 @@
 #ifndef OPENCV_CORE_BUFFER_POOL_HPP
 #define OPENCV_CORE_BUFFER_POOL_HPP
 
+#ifdef _MSC_VER
+#pragma warning(push)
+#pragma warning(disable: 4265)
+#endif
+
 namespace cv
 {
 
@@ -28,4 +33,8 @@ public:
 
 }
 
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
+
 #endif // OPENCV_CORE_BUFFER_POOL_HPP