projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
07f1d9a
)
usb: chipidea: udc: check request status before setting device address
author
Xu Yang
<xu.yang_2@nxp.com>
Thu, 23 Jun 2022 03:02:42 +0000
(11:02 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 29 Jun 2022 07:03:27 +0000
(09:03 +0200)
commit
b24346a240b36cfc4df194d145463874985aa29b
upstream.
The complete() function may be called even though request is not
completed. In this case, it's necessary to check request status so
as not to set device address wrongly.
Fixes:
10775eb17bee
("usb: chipidea: udc: update gadget states according to ch9")
cc: <stable@vger.kernel.org>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Link:
https://lore.kernel.org/r/20220623030242.41796-1-xu.yang_2@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/udc.c
patch
|
blob
|
history
diff --git
a/drivers/usb/chipidea/udc.c
b/drivers/usb/chipidea/udc.c
index
8834ca6
..
aacc377
100644
(file)
--- a/
drivers/usb/chipidea/udc.c
+++ b/
drivers/usb/chipidea/udc.c
@@
-1040,6
+1040,9
@@
isr_setup_status_complete(struct usb_ep *ep, struct usb_request *req)
struct ci_hdrc *ci = req->context;
unsigned long flags;
+ if (req->status < 0)
+ return;
+
if (ci->setaddr) {
hw_usb_set_address(ci, ci->address);
ci->setaddr = false;