gpio: pisosr: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 27 Aug 2020 20:08:26 +0000 (22:08 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 28 Aug 2020 18:15:51 +0000 (20:15 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-pisosr.c

index 6698fea..8e04054 100644 (file)
@@ -148,12 +148,9 @@ static int pisosr_gpio_probe(struct spi_device *spi)
                return -ENOMEM;
 
        gpio->load_gpio = devm_gpiod_get_optional(dev, "load", GPIOD_OUT_LOW);
-       if (IS_ERR(gpio->load_gpio)) {
-               ret = PTR_ERR(gpio->load_gpio);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "Unable to allocate load GPIO\n");
-               return ret;
-       }
+       if (IS_ERR(gpio->load_gpio))
+               return dev_err_probe(dev, PTR_ERR(gpio->load_gpio),
+                                    "Unable to allocate load GPIO\n");
 
        mutex_init(&gpio->lock);