Bluetooth: Fix incorrect LE CoC PDU length restriction based on HCI MTU

commit 72c6fb915ff2d30ae14053edee4f0d30019bad76 upstream.

The l2cap_create_le_flowctl_pdu() function that l2cap_segment_le_sdu()
calls is perfectly capable of doing packet fragmentation if given bigger
PDUs than the HCI buffers allow. Forcing the PDU length based on the HCI
MTU (conn->mtu) would therefore needlessly strict operation on hardware
with limited LE buffers (e.g. both Intel and Broadcom seem to have this
set to just 27 bytes).

This patch removes the restriction and makes it possible to send PDUs of
the full length that the remote MPS value allows.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 6afa3b4..0007c9e 100644 (file)
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -2608,12 +2608,8 @@ static int l2cap_segment_le_sdu(struct l2cap_chan *chan,
 
        BT_DBG("chan %p, msg %p, len %zu", chan, msg, len);
 
-       pdu_len = chan->conn->mtu - L2CAP_HDR_SIZE;
-
-       pdu_len = min_t(size_t, pdu_len, chan->remote_mps);
-
        sdu_len = len;
-       pdu_len -= L2CAP_SDULEN_SIZE;
+       pdu_len = chan->remote_mps - L2CAP_SDULEN_SIZE;
 
        while (len > 0) {
                if (len <= pdu_len)