projects
/
platform
/
upstream
/
nodejs.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b9a0eb0
)
crypto: don't touch ssl_ in Connection
author
Fedor Indutny
<fedor.indutny@gmail.com>
Mon, 19 Aug 2013 16:34:34 +0000
(20:34 +0400)
committer
Fedor Indutny
<fedor.indutny@gmail.com>
Mon, 19 Aug 2013 16:34:34 +0000
(20:34 +0400)
`ssl_` is a property of SSLWrap class, don't touch it, and definitely
don't zero it in constructor.
src/node_crypto.h
patch
|
blob
|
history
diff --git
a/src/node_crypto.h
b/src/node_crypto.h
index
56055a9
..
2d2b00a
100644
(file)
--- a/
src/node_crypto.h
+++ b/
src/node_crypto.h
@@
-267,7
+267,6
@@
class Connection : public SSLWrap<Connection>, public ObjectWrap {
: SSLWrap<Connection>(sc, kind),
hello_offset_(0) {
bio_read_ = bio_write_ = NULL;
- ssl_ = NULL;
hello_parser_.Start(SSLWrap<Connection>::OnClientHello,
OnClientHelloParseEnd,
this);
@@
-275,11
+274,6
@@
class Connection : public SSLWrap<Connection>, public ObjectWrap {
}
~Connection() {
- if (ssl_ != NULL) {
- SSL_free(ssl_);
- ssl_ = NULL;
- }
-
#ifdef SSL_CTRL_SET_TLSEXT_SERVERNAME_CB
sniObject_.Dispose();
sniContext_.Dispose();