Make AttributeSet::getFnAttributes() return an AttributeSet instead of an Attribute.
authorBill Wendling <isanbard@gmail.com>
Mon, 21 Jan 2013 21:57:40 +0000 (21:57 +0000)
committerBill Wendling <isanbard@gmail.com>
Mon, 21 Jan 2013 21:57:40 +0000 (21:57 +0000)
This is more code to isolate the use of the Attribute class to that of just
holding one attribute instead of a collection of attributes.

llvm-svn: 173095

clang/lib/CodeGen/CodeGenModule.cpp

index 28f5974..5e09e47 100644 (file)
@@ -1938,10 +1938,10 @@ static void replaceUsesOfNonProtoConstant(llvm::Constant *old,
     llvm::AttributeSet oldAttrs = callSite.getAttributes();
 
     // Collect any return attributes from the call.
-    llvm::Attribute returnAttrs = oldAttrs.getRetAttributes();
-    if (returnAttrs.hasAttributes())
+    if (oldAttrs.hasAttributes(llvm::AttributeSet::ReturnIndex))
       newAttrs.push_back(llvm::AttributeWithIndex::get(
-                                llvm::AttributeSet::ReturnIndex, returnAttrs));
+                                llvm::AttributeSet::ReturnIndex,
+                                oldAttrs.getRetAttributes()));
 
     // If the function was passed too few arguments, don't transform.
     unsigned newNumArgs = newFn->arg_size();
@@ -1966,11 +1966,11 @@ static void replaceUsesOfNonProtoConstant(llvm::Constant *old,
     if (dontTransform)
       continue;
 
-    llvm::Attribute fnAttrs = oldAttrs.getFnAttributes();
     if (oldAttrs.hasAttributes(llvm::AttributeSet::FunctionIndex))
       newAttrs.push_back(llvm::
-                       AttributeWithIndex::get(llvm::AttributeSet::FunctionIndex,
-                                               fnAttrs));
+                      AttributeWithIndex::get(newFn->getContext(),
+                                              llvm::AttributeSet::FunctionIndex,
+                                              oldAttrs.getFnAttributes()));
 
     // Okay, we can transform this.  Create the new call instruction and copy
     // over the required information.