net: hns3: use memcpy to simplify code
authorPeng Li <lipeng321@huawei.com>
Fri, 27 Aug 2021 09:28:20 +0000 (17:28 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Aug 2021 10:20:21 +0000 (11:20 +0100)
Use memcpy to copy req->msg.resp_data to resp->additional_info,
to simplify the code and improve a little efficiency.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c

index 5030950..d42e271 100644 (file)
@@ -163,8 +163,6 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev)
        struct hclgevf_desc *desc;
        u16 *msg_q;
        u16 flag;
-       u8 *temp;
-       int i;
 
        resp = &hdev->mbx_resp;
        crq = &hdev->hw.cmq.crq;
@@ -212,11 +210,8 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev)
                        resp->resp_status =
                                hclgevf_resp_to_errno(req->msg.resp_status);
 
-                       temp = (u8 *)req->msg.resp_data;
-                       for (i = 0; i < HCLGE_MBX_MAX_RESP_DATA_SIZE; i++) {
-                               resp->additional_info[i] = *temp;
-                               temp++;
-                       }
+                       memcpy(resp->additional_info, req->msg.resp_data,
+                              HCLGE_MBX_MAX_RESP_DATA_SIZE * sizeof(u8));
 
                        /* If match_id is not zero, it means PF support
                         * match_id. If the match_id is right, VF get the