tu: Use right enum for compute active_shader_stages
authorConnor Abbott <cwabbott0@gmail.com>
Tue, 29 Nov 2022 14:40:43 +0000 (15:40 +0100)
committerEric Engestrom <eric@engestrom.ch>
Wed, 30 Nov 2022 21:12:44 +0000 (21:12 +0000)
This is VkShaderStageFlags, not VkPipelineStageFlags. Fixes preloading
descriptors for compute dispatches.

Fixes: d862a2ebcbf ("turnip: Only emit descriptor loads for active stages in the pipeline.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20059>
(cherry picked from commit 0a0a04bdaa6faf1dd3e937f7087ae1c4f240c916)

.pick_status.json
src/freedreno/vulkan/tu_pipeline.c

index 5ce1325..b8c1cfe 100644 (file)
         "description": "tu: Use right enum for compute active_shader_stages",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": "d862a2ebcbf94374e0ab0bd1c63bc45020a2ecef"
     },
index eb77042..214f96f 100644 (file)
@@ -4994,7 +4994,7 @@ tu_compute_pipeline_create(VkDevice device,
 
    pipeline->executables_mem_ctx = ralloc_context(NULL);
    util_dynarray_init(&pipeline->executables, pipeline->executables_mem_ctx);
-   pipeline->active_stages = VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT;
+   pipeline->active_stages = VK_SHADER_STAGE_COMPUTE_BIT;
 
    struct tu_shader_key key = { };
    tu_shader_key_init(&key, stage_info, dev);