Staging: greybus: light: Prefer kcalloc over kzalloc
authorKarthik Tummala <karthik@techveda.org>
Mon, 8 May 2017 12:35:55 +0000 (18:05 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 May 2017 05:41:59 +0000 (07:41 +0200)
Fixed following checkpatch.pl warning:
 * WARNING: Prefer kcalloc over kzalloc with multiply

Instead of specifying no.of bytes * size as argument
in kzalloc, prefer kcalloc.

Signed-off-by: Karthik Tummala <karthik@techveda.org>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Changes for v2:
- Changed subject line & fixed typo as suggested by
  Rui Miguel Silva
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/light.c

index 1681362..861a249 100644 (file)
@@ -1030,7 +1030,7 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id)
        light->channels_count = conf.channel_count;
        light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL);
 
-       light->channels = kzalloc(light->channels_count *
+       light->channels = kcalloc(light->channels_count,
                                  sizeof(struct gb_channel), GFP_KERNEL);
        if (!light->channels)
                return -ENOMEM;
@@ -1167,7 +1167,7 @@ static int gb_lights_create_all(struct gb_lights *glights)
        if (ret < 0)
                goto out;
 
-       glights->lights = kzalloc(glights->lights_count *
+       glights->lights = kcalloc(glights->lights_count,
                                  sizeof(struct gb_light), GFP_KERNEL);
        if (!glights->lights) {
                ret = -ENOMEM;