projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f5aa168
)
drm/vc4: fix error code in vc4_check_tex_size()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Wed, 22 Jun 2022 12:25:15 +0000
(15:25 +0300)
committer
Maxime Ripard
<maxime@cerno.tech>
Wed, 22 Jun 2022 14:41:30 +0000
(16:41 +0200)
The vc4_check_tex_size() function is supposed to return false on error
but this error path accidentally returns -ENODEV (which means true).
Fixes:
30f8c74ca9b7
("drm/vc4: Warn if some v3d code is run on BCM2711")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link:
https://patchwork.freedesktop.org/patch/msgid/YrMKK89/viQiaiAg@kili
drivers/gpu/drm/vc4/vc4_validate.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/vc4/vc4_validate.c
b/drivers/gpu/drm/vc4/vc4_validate.c
index
833eb62
..
2feba55
100644
(file)
--- a/
drivers/gpu/drm/vc4/vc4_validate.c
+++ b/
drivers/gpu/drm/vc4/vc4_validate.c
@@
-170,7
+170,7
@@
vc4_check_tex_size(struct vc4_exec_info *exec, struct drm_gem_cma_object *fbo,
uint32_t utile_h = utile_height(cpp);
if (WARN_ON_ONCE(vc4->is_vc5))
- return
-ENODEV
;
+ return
false
;
/* The shaded vertex format stores signed 12.4 fixed point
* (-2048,2047) offsets from the viewport center, so we should