EDAC, mv64x60_edac: Fix an error code in probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 28 Jan 2015 19:13:51 +0000 (22:13 +0300)
committerBorislav Petkov <bp@suse.de>
Fri, 30 Jan 2015 16:00:43 +0000 (17:00 +0100)
If edac_mc_add_mc() fails then we should preserve the error code, but
instead the current code returns success.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: http://lkml.kernel.org/r/20150128191351.GC10259@mwanda
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/mv64x60_edac.c

index 6366e88..0574e1b 100644 (file)
@@ -789,7 +789,8 @@ static int mv64x60_mc_err_probe(struct platform_device *pdev)
        ctl = (ctl & 0xff00ffff) | 0x10000;
        out_le32(pdata->mc_vbase + MV64X60_SDRAM_ERR_ECC_CNTL, ctl);
 
-       if (edac_mc_add_mc(mci)) {
+       res = edac_mc_add_mc(mci);
+       if (res) {
                edac_dbg(3, "failed edac_mc_add_mc()\n");
                goto err;
        }