USB: typec: tcpm: Fix PR_SWAP error handling
authorKyle Tso <kyletso@google.com>
Thu, 10 Dec 2020 16:05:19 +0000 (17:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Dec 2020 09:51:38 +0000 (10:51 +0100)
PD rev3.0 8.3.3.16.3.6 PE_PRS_SRC_SNK_Wait_Source_on State
The Policy Enging Shall transition to the ErrorRecovery state when the
PSSourceOnTimer times out ...

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Badhri Jagan Sridharan <badhri@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Kyle Tso <kyletso@google.com>
Signed-off-by: Will McVicker <willmcvicker@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20201210160521.3417426-4-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpm.c

index fa0500a03413fcbd7ef23e6a1f429bca73d92119..3f9edc8a9a57f8cdfd84914d38aa883f26b670b7 100644 (file)
@@ -3738,7 +3738,7 @@ static void run_state_machine(struct tcpm_port *port)
                        tcpm_set_state(port, ERROR_RECOVERY, 0);
                        break;
                }
-               tcpm_set_state_cond(port, SNK_UNATTACHED, PD_T_PS_SOURCE_ON);
+               tcpm_set_state(port, ERROR_RECOVERY, PD_T_PS_SOURCE_ON);
                break;
        case PR_SWAP_SRC_SNK_SINK_ON:
                /* Set the vbus disconnect threshold for implicit contract */