drm/i915/params: set i915.enable_hangcheck permissions to 0600
authorJani Nikula <jani.nikula@intel.com>
Thu, 27 Dec 2018 14:33:40 +0000 (16:33 +0200)
committerJani Nikula <jani.nikula@intel.com>
Mon, 31 Dec 2018 13:27:41 +0000 (15:27 +0200)
i915.enable_hangcheck has been an outlier since its introduction in
commit 3e0dc6b01f53 ("drm/i915: hangcheck disable parameter") with 0644
permissions, while all the rest are either 0400 or 0600. Follow suit
with 0600.

IGT never reads the value, so there should be no impact.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/5c8f7d1a1654436d38919b7419a209c129db8ad0.1545920737.git.jani.nikula@intel.com
drivers/gpu/drm/i915/i915_params.c

index 81c73bf..9f0539b 100644 (file)
@@ -77,7 +77,7 @@ i915_param_named(error_capture, bool, 0600,
        "triaging and debugging hangs.");
 #endif
 
-i915_param_named_unsafe(enable_hangcheck, bool, 0644,
+i915_param_named_unsafe(enable_hangcheck, bool, 0600,
        "Periodically check GPU activity for detecting hangs. "
        "WARNING: Disabling this can cause system wide hangs. "
        "(default: true)");