drm/amd/display: Set number of pipes to 1 if the second pipe was disabled
authorNikola Cornij <nikola.cornij@amd.com>
Wed, 28 Aug 2019 22:30:43 +0000 (18:30 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 3 Oct 2019 14:10:57 +0000 (09:10 -0500)
[why]
Some ODM-related register settings are inconsistently updated by VBIOS, causing
the state in DC to be invalid, which would then end up crashing in certain
use-cases (such as disable/enable device).

[how]
Check the enabled status of the second pipe when determining the number of
OPTC sources. If the second pipe is disabled, set the number of sources to 1
regardless of other settings (that may not be updated correctly).

Signed-off-by: Nikola Cornij <nikola.cornij@amd.com>
Reviewed-by: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_optc.c

index 2137e2b..dda9099 100644 (file)
@@ -287,6 +287,10 @@ void optc2_get_optc_source(struct timing_generator *optc,
                *num_of_src_opp = 2;
        else
                *num_of_src_opp = 1;
+
+       /* Work around VBIOS not updating OPTC_NUM_OF_INPUT_SEGMENT */
+       if (*src_opp_id_1 == 0xf)
+               *num_of_src_opp = 1;
 }
 
 void optc2_set_dwb_source(struct timing_generator *optc,