ttyprintk: Removed unnecessary TTY ioctl callback
authorSamo Pogačnik <samo_pogacnik@t-2.net>
Tue, 27 Apr 2021 11:43:26 +0000 (13:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 16:29:12 +0000 (18:29 +0200)
It turns-out, that TIOCCONS is completely handled in tty_io.c, so
the current local ioctl callback is of no real use.

Signed-off-by: Samo Pogačnik <samo_pogacnik@t-2.net>
Link: https://lore.kernel.org/r/1502946c760b1aae3ad9cffcf4ea3b9f37206585.camel@t-2.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/ttyprintk.c

index 620065b..219fa13 100644 (file)
@@ -109,7 +109,6 @@ static int tpk_write(struct tty_struct *tty,
        unsigned long flags;
        int ret;
 
-
        /* exclusive use of tpk_printk within this tty */
        spin_lock_irqsave(&tpkp->spinlock, flags);
        ret = tpk_printk(buf, count);
@@ -127,27 +126,6 @@ static unsigned int tpk_write_room(struct tty_struct *tty)
 }
 
 /*
- * TTY operations ioctl function.
- */
-static int tpk_ioctl(struct tty_struct *tty,
-                       unsigned int cmd, unsigned long arg)
-{
-       struct ttyprintk_port *tpkp = tty->driver_data;
-
-       if (!tpkp)
-               return -EINVAL;
-
-       switch (cmd) {
-       /* Stop TIOCCONS */
-       case TIOCCONS:
-               return -EOPNOTSUPP;
-       default:
-               return -ENOIOCTLCMD;
-       }
-       return 0;
-}
-
-/*
  * TTY operations hangup function.
  */
 static void tpk_hangup(struct tty_struct *tty)
@@ -176,7 +154,6 @@ static const struct tty_operations ttyprintk_ops = {
        .close = tpk_close,
        .write = tpk_write,
        .write_room = tpk_write_room,
-       .ioctl = tpk_ioctl,
        .hangup = tpk_hangup,
 };