iio: as3935: Use sysfs_emit()
authorLars-Peter Clausen <lars@metafoo.de>
Thu, 16 Dec 2021 18:52:09 +0000 (19:52 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 23 Jan 2022 18:03:36 +0000 (18:03 +0000)
sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it
knows about the sysfs buffer specifics and has some built-in checks for
size and alignment.

Use sysfs_emit() to format the custom `noise_level_tripped` device
attribute of the as3935 driver.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211216185217.1054495-6-lars@metafoo.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/proximity/as3935.c

index 51f4f92..bd7595d 100644 (file)
@@ -122,7 +122,7 @@ static ssize_t as3935_sensor_sensitivity_show(struct device *dev,
                return ret;
        val = (val & AS3935_AFE_MASK) >> 1;
 
-       return sprintf(buf, "%d\n", val);
+       return sysfs_emit(buf, "%d\n", val);
 }
 
 static ssize_t as3935_sensor_sensitivity_store(struct device *dev,
@@ -153,7 +153,7 @@ static ssize_t as3935_noise_level_tripped_show(struct device *dev,
        int ret;
 
        mutex_lock(&st->lock);
-       ret = sprintf(buf, "%d\n", !time_after(jiffies, st->noise_tripped + HZ));
+       ret = sysfs_emit(buf, "%d\n", !time_after(jiffies, st->noise_tripped + HZ));
        mutex_unlock(&st->lock);
 
        return ret;