wifi: rtl8xxxu: Improve rtl8xxxu_queue_select
authorBitterblue Smith <rtl8821cerfe2@gmail.com>
Sun, 18 Sep 2022 12:47:05 +0000 (15:47 +0300)
committerKalle Valo <kvalo@kernel.org>
Thu, 29 Sep 2022 06:18:42 +0000 (09:18 +0300)
Remove the unused ieee80211_hw* parameter, and pass ieee80211_hdr*
instead of relying on skb->data having the right value at the time
the function is called.

This doesn't change the functionality at all.

Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)")
Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: Jes Sorensen <jes@trained-monkey.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/2af44c28-1c12-46b9-85b9-011560bf7f7e@gmail.com
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c

index 731aba2..ac641a5 100644 (file)
@@ -4767,9 +4767,8 @@ static u32 rtl8xxxu_80211_to_rtl_queue(u32 queue)
        return rtlqueue;
 }
 
-static u32 rtl8xxxu_queue_select(struct ieee80211_hw *hw, struct sk_buff *skb)
+static u32 rtl8xxxu_queue_select(struct ieee80211_hdr *hdr, struct sk_buff *skb)
 {
-       struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
        u32 queue;
 
        if (ieee80211_is_mgmt(hdr->frame_control))
@@ -5119,7 +5118,7 @@ static void rtl8xxxu_tx(struct ieee80211_hw *hw,
        if (control && control->sta)
                sta = control->sta;
 
-       queue = rtl8xxxu_queue_select(hw, skb);
+       queue = rtl8xxxu_queue_select(hdr, skb);
 
        tx_desc = skb_push(skb, tx_desc_size);