Remove exclusion of two runtime assemblies from build in SuperILC (dotnet/coreclr...
authorJan Vorlicek <janvorli@microsoft.com>
Wed, 13 Nov 2019 21:05:06 +0000 (22:05 +0100)
committerGitHub <noreply@github.com>
Wed, 13 Nov 2019 21:05:06 +0000 (22:05 +0100)
The System.Private.CoreLib builds fine using crossgen2 now (I've been
building it locally for a couple of weeks already).
I've also tried to remove exclusion of the
Microsoft.Diagnostics.Tracing.TraceEvent and it is passing now as well.

Commit migrated from https://github.com/dotnet/coreclr/commit/1fae9e35c6fbd831db551543bc0be32e37fc4e11

src/coreclr/src/tools/ReadyToRun.SuperIlc/BuildFolderSet.cs

index fb0c1eb..6209be4 100644 (file)
@@ -44,10 +44,6 @@ namespace ReadyToRun.SuperIlc
 
             // TODO (TRylek): problem related to devirtualization of method without IL - System.Enum.Equals(object)
             new FrameworkExclusion("System.ComponentModel.TypeConverter", "TODO trylek - devirtualization of method without IL", crossgen2Only: true),
-
-            // TODO: additional framework build failures
-            new FrameworkExclusion("Microsoft.Diagnostics.Tracing.TraceEvent", "Assert failure in JIT", crossgen2Only: true),
-            new FrameworkExclusion("System.Private.CoreLib", "Assert failure in JIT", crossgen2Only: true),
         };
 
         private readonly IEnumerable<BuildFolder> _buildFolders;