cmd: fdt: Use env_set_hex() for "get addr" and "get size"
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Sat, 11 Mar 2023 16:29:21 +0000 (17:29 +0100)
committerSimon Glass <sjg@chromium.org>
Sun, 2 Apr 2023 18:53:53 +0000 (06:53 +1200)
The 'fdt get addr' and 'env get size' is always assumed to be hex
value, drop the prefix, and outright switch to env_set_hex(). Since
this might break existing users who depend on the existing behavior
with 0x prefix, this is a separate patch.

Revert if this breaks anything.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
cmd/fdt.c

index 04b664e..87d9a38 100644 (file)
--- a/cmd/fdt.c
+++ b/cmd/fdt.c
@@ -475,18 +475,9 @@ static int do_fdt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
                                        if (ret != 0)
                                                return ret;
                                } else if (subcmd[0] == 'a') {
-                                       /* Get address */
-                                       char buf[19];
-
-                                       snprintf(buf, sizeof(buf), "%lx",
-                                                (ulong)map_to_sysmem(nodep));
-                                       env_set(var, buf);
+                                       env_set_hex(var, (ulong)map_to_sysmem(nodep));
                                } else if (subcmd[0] == 's') {
-                                       /* Get size */
-                                       char buf[11];
-
-                                       sprintf(buf, "0x%08X", len);
-                                       env_set(var, buf);
+                                       env_set_hex(var, len);
                                } else
                                        return CMD_RET_USAGE;
                                return 0;