iommu/amd: Fix union of bitfields in intcapxt support
authorDavid Woodhouse <dwmw@amazon.co.uk>
Wed, 11 Nov 2020 14:43:21 +0000 (14:43 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 11 Nov 2020 22:01:57 +0000 (23:01 +0100)
All the bitfields in here are overlaid on top of each other since
they're a union. Change the second u64 to be in a struct so it does
the intended thing.

Fixes: b5c3786ee370 ("iommu/amd: Use msi_msg shadow structs")
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20201111144322.1659970-2-dwmw2@infradead.org
drivers/iommu/amd/init.c

index 263670d..c2769f2 100644 (file)
@@ -1967,13 +1967,15 @@ static int iommu_setup_msi(struct amd_iommu *iommu)
 
 union intcapxt {
        u64     capxt;
-       u64     reserved_0              :  2,
-               dest_mode_logical       :  1,
-               reserved_1              :  5,
-               destid_0_23             : 24,
-               vector                  :  8,
-               reserved_2              : 16,
-               destid_24_31            :  8;
+       struct {
+               u64     reserved_0              :  2,
+                       dest_mode_logical       :  1,
+                       reserved_1              :  5,
+                       destid_0_23             : 24,
+                       vector                  :  8,
+                       reserved_2              : 16,
+                       destid_24_31            :  8;
+       };
 } __attribute__ ((packed));
 
 /*