flacenc: Don't crash if there is no image tag information
authorSebastian Dröge <slomo@circular-chaos.org>
Sun, 28 Jul 2013 16:04:32 +0000 (18:04 +0200)
committerSebastian Dröge <slomo@circular-chaos.org>
Sun, 28 Jul 2013 16:04:32 +0000 (18:04 +0200)
https://bugzilla.gnome.org/show_bug.cgi?id=705018

ext/flac/gstflacenc.c

index 3e6cd8a..ad136df 100644 (file)
@@ -630,11 +630,15 @@ gst_flac_enc_set_metadata (GstFlacEnc * flacenc, GstAudioInfo * info,
           continue;
       }
 
+      structure = gst_sample_get_info (sample);
+      if (!structure) {
+        GST_ERROR_OBJECT (flacenc, "No image tag info");
+        continue;
+      }
+
       flacenc->meta[entries] =
           FLAC__metadata_object_new (FLAC__METADATA_TYPE_PICTURE);
 
-      structure = gst_sample_get_info (sample);
-
       gst_structure_get (structure, "image-type", GST_TYPE_TAG_IMAGE_TYPE,
           &image_type, NULL);
       /* Convert to ID3v2 APIC image type */