projects
/
platform
/
upstream
/
gst-plugins-good.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1fbb6d3
)
flacenc: Don't crash if there is no image tag information
author
Sebastian Dröge
<slomo@circular-chaos.org>
Sun, 28 Jul 2013 16:04:32 +0000
(18:04 +0200)
committer
Sebastian Dröge
<slomo@circular-chaos.org>
Sun, 28 Jul 2013 16:04:32 +0000
(18:04 +0200)
https://bugzilla.gnome.org/show_bug.cgi?id=705018
ext/flac/gstflacenc.c
patch
|
blob
|
history
diff --git
a/ext/flac/gstflacenc.c
b/ext/flac/gstflacenc.c
index
3e6cd8a
..
ad136df
100644
(file)
--- a/
ext/flac/gstflacenc.c
+++ b/
ext/flac/gstflacenc.c
@@
-630,11
+630,15
@@
gst_flac_enc_set_metadata (GstFlacEnc * flacenc, GstAudioInfo * info,
continue;
}
+ structure = gst_sample_get_info (sample);
+ if (!structure) {
+ GST_ERROR_OBJECT (flacenc, "No image tag info");
+ continue;
+ }
+
flacenc->meta[entries] =
FLAC__metadata_object_new (FLAC__METADATA_TYPE_PICTURE);
- structure = gst_sample_get_info (sample);
-
gst_structure_get (structure, "image-type", GST_TYPE_TAG_IMAGE_TYPE,
&image_type, NULL);
/* Convert to ID3v2 APIC image type */