Make BrowserWindowProxy guestId non-writeable
authorKevin Sawicki <kevinsawicki@gmail.com>
Thu, 9 Jun 2016 20:41:42 +0000 (13:41 -0700)
committerKevin Sawicki <kevinsawicki@gmail.com>
Thu, 9 Jun 2016 20:41:42 +0000 (13:41 -0700)
lib/renderer/override.js

index 5667e5e16f55fb255ec76d054b04068039fbf1c6..ced2318e7188867a13676793bd6e13ac032ce5b2 100644 (file)
@@ -25,7 +25,13 @@ var BrowserWindowProxy = (function () {
   }
 
   function BrowserWindowProxy (guestId1) {
-    this.guestId = guestId1
+    Object.defineProperty(this, 'guestId', {
+      configurable: false,
+      enumerable: true,
+      writeable: false,
+      value: guestId1
+    })
+
     this.closed = false
     ipcRenderer.once('ELECTRON_GUEST_WINDOW_MANAGER_WINDOW_CLOSED_' + this.guestId, () => {
       BrowserWindowProxy.remove(this.guestId)