shell: End grab if the grabbed shell surface has been destroyed
authorRob Bradford <rob@linux.intel.com>
Mon, 20 May 2013 11:09:20 +0000 (12:09 +0100)
committerKristian Høgsberg <krh@bitplanet.net>
Mon, 20 May 2013 20:53:49 +0000 (16:53 -0400)
The shell_grab_start function sets up a destroy notification on the
shell surface such that when the shell surface is destroyed the pointer
on the grab to the shell surface is set to NULL.

We must therefore check whether the shell surface is NULL and end the
grab if it is.

https://bugs.freedesktop.org/show_bug.cgi?id=64689

src/shell.c

index f5d5bff..7261570 100644 (file)
@@ -1296,7 +1296,7 @@ busy_cursor_grab_focus(struct weston_pointer_grab *base)
                                                 pointer->x, pointer->y,
                                                 &sx, &sy);
 
-       if (grab->shsurf->surface != surface) {
+       if (!grab->shsurf || grab->shsurf->surface != surface) {
                shell_grab_end(grab);
                free(grab);
        }