projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3123109
)
spi: rpc-if: Fix RPM imbalance in probe error path
author
Geert Uytterhoeven
<geert+renesas@glider.be>
Tue, 29 Mar 2022 14:00:39 +0000
(16:00 +0200)
committer
Mark Brown
<broonie@kernel.org>
Mon, 4 Apr 2022 07:38:59 +0000
(08:38 +0100)
If rpcif_hw_init() fails, Runtime PM is left enabled.
Fixes:
b04cc0d912eb80d3
("memory: renesas-rpc-if: Add support for RZ/G2L")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link:
https://lore.kernel.org/r/1c78a1f447d019bb66b6e7787f520ae78821e2ae.1648562287.git.geert+renesas@glider.be
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-rpc-if.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-rpc-if.c
b/drivers/spi/spi-rpc-if.c
index
fe82f35
..
24ec1c8
100644
(file)
--- a/
drivers/spi/spi-rpc-if.c
+++ b/
drivers/spi/spi-rpc-if.c
@@
-158,14
+158,18
@@
static int rpcif_spi_probe(struct platform_device *pdev)
error = rpcif_hw_init(rpc, false);
if (error)
-
return error
;
+
goto out_disable_rpm
;
error = spi_register_controller(ctlr);
if (error) {
dev_err(&pdev->dev, "spi_register_controller failed\n");
-
rpcif_disable_rpm(rpc)
;
+
goto out_disable_rpm
;
}
+ return 0;
+
+out_disable_rpm:
+ rpcif_disable_rpm(rpc);
return error;
}