libnvdimm/btt: Remove unnecessary code in btt_freelist_init
authorVishal Verma <vishal.l.verma@intel.com>
Thu, 28 Feb 2019 00:06:26 +0000 (17:06 -0700)
committerDan Williams <dan.j.williams@intel.com>
Thu, 28 Feb 2019 17:42:51 +0000 (09:42 -0800)
We call btt_log_read() twice, once to get the 'old' log entry, and again
to get the 'new' entry. However, we have no use for the 'old' entry, so
remove it.

Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/btt.c

index b123b0d..cd4fa87 100644 (file)
@@ -541,9 +541,9 @@ static int arena_clear_freelist_error(struct arena_info *arena, u32 lane)
 
 static int btt_freelist_init(struct arena_info *arena)
 {
-       int old, new, ret;
+       int new, ret;
        u32 i, map_entry;
-       struct log_entry log_new, log_old;
+       struct log_entry log_new;
 
        arena->freelist = kcalloc(arena->nfree, sizeof(struct free_entry),
                                        GFP_KERNEL);
@@ -551,10 +551,6 @@ static int btt_freelist_init(struct arena_info *arena)
                return -ENOMEM;
 
        for (i = 0; i < arena->nfree; i++) {
-               old = btt_log_read(arena, i, &log_old, LOG_OLD_ENT);
-               if (old < 0)
-                       return old;
-
                new = btt_log_read(arena, i, &log_new, LOG_NEW_ENT);
                if (new < 0)
                        return new;