Bug fixes for memory leak in NSProviderMemoryCache.

Add free logic for memory leak in NSStorageWrite function.

Change-Id: Ifd8ef3b08cc61e798255be5f472df6e9d4e3575a
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10901
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

diff --git a/service/notification/src/provider/NSProviderMemoryCache.c b/service/notification/src/provider/NSProviderMemoryCache.c
index 712aa52bedad75e281e89abaf3584c9119b0f416..710cee1a19d052e5985f6ab938122a59fd58dd61 100644 (file)
--- a/service/notification/src/provider/NSProviderMemoryCache.c
+++ b/service/notification/src/provider/NSProviderMemoryCache.c
@@ -203,6 +203,8 @@ NSResult NSStorageWrite(NSCacheList * list, NSCacheElement * newObj)
         if (it)\r
         {\r
             NS_LOG(DEBUG, "already registered for topic name");\r
+            OICFree(topicData->topicName);\r
+            OICFree(topicData);\r
             pthread_mutex_unlock(&NSCacheMutex);\r
             return NS_FAIL;\r
         }\r
@@ -217,6 +219,8 @@ NSResult NSStorageWrite(NSCacheList * list, NSCacheElement * newObj)
         if (it)\r
         {\r
             NS_LOG(DEBUG, "already registered for topic name");\r
+            OICFree(topicData->topicName);\r
+            OICFree(topicData);\r
             pthread_mutex_unlock(&NSCacheMutex);\r
             return NS_FAIL;\r
         }\r
@@ -231,6 +235,8 @@ NSResult NSStorageWrite(NSCacheList * list, NSCacheElement * newObj)
         if (it)\r
         {\r
             NS_LOG(DEBUG, "already registered for topic name");\r
+            OICFree(topicData->topicName);\r
+            OICFree(topicData);\r
             pthread_mutex_unlock(&NSCacheMutex);\r
             return NS_FAIL;\r
         }\r