dmaengine: idxd: define table offset multiplier
authorDave Jiang <dave.jiang@intel.com>
Fri, 30 Oct 2020 15:51:56 +0000 (08:51 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 9 Nov 2020 11:47:46 +0000 (17:17 +0530)
Convert table offset multiplier magic number to a define.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/160407311690.839435.6941865731867828234.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/init.c
drivers/dma/idxd/registers.h

index c24106e..45b0eac 100644 (file)
@@ -214,17 +214,14 @@ static void idxd_read_table_offsets(struct idxd_device *idxd)
        struct device *dev = &idxd->pdev->dev;
 
        offsets.bits[0] = ioread64(idxd->reg_base + IDXD_TABLE_OFFSET);
-       offsets.bits[1] = ioread64(idxd->reg_base + IDXD_TABLE_OFFSET
-                       + sizeof(u64));
-       idxd->grpcfg_offset = offsets.grpcfg * 0x100;
+       offsets.bits[1] = ioread64(idxd->reg_base + IDXD_TABLE_OFFSET + sizeof(u64));
+       idxd->grpcfg_offset = offsets.grpcfg * IDXD_TABLE_MULT;
        dev_dbg(dev, "IDXD Group Config Offset: %#x\n", idxd->grpcfg_offset);
-       idxd->wqcfg_offset = offsets.wqcfg * 0x100;
-       dev_dbg(dev, "IDXD Work Queue Config Offset: %#x\n",
-               idxd->wqcfg_offset);
-       idxd->msix_perm_offset = offsets.msix_perm * 0x100;
-       dev_dbg(dev, "IDXD MSIX Permission Offset: %#x\n",
-               idxd->msix_perm_offset);
-       idxd->perfmon_offset = offsets.perfmon * 0x100;
+       idxd->wqcfg_offset = offsets.wqcfg * IDXD_TABLE_MULT;
+       dev_dbg(dev, "IDXD Work Queue Config Offset: %#x\n", idxd->wqcfg_offset);
+       idxd->msix_perm_offset = offsets.msix_perm * IDXD_TABLE_MULT;
+       dev_dbg(dev, "IDXD MSIX Permission Offset: %#x\n", idxd->msix_perm_offset);
+       idxd->perfmon_offset = offsets.perfmon * IDXD_TABLE_MULT;
        dev_dbg(dev, "IDXD Perfmon Offset: %#x\n", idxd->perfmon_offset);
 }
 
index 6f2f736..d29a58e 100644 (file)
@@ -102,6 +102,8 @@ union offsets_reg {
        u64 bits[2];
 } __packed;
 
+#define IDXD_TABLE_MULT                        0x100
+
 #define IDXD_GENCFG_OFFSET             0x80
 union gencfg_reg {
        struct {