[clangd] Unbreak mac build differently 0c96a92d8666b8
authorNico Weber <thakis@chromium.org>
Thu, 1 Jul 2021 14:49:10 +0000 (10:49 -0400)
committerNico Weber <thakis@chromium.org>
Thu, 1 Jul 2021 14:51:27 +0000 (10:51 -0400)
This reverts b56e5f8a10c1 (and follow-up f6db88535cb) and instead
restores the state we had before 0c96a92d8666b8: ClangdMain.cpp
includes Features.inc before including Transport.h.

This is a bit ugly, but it matches the former state and making Transport.h
include Features.h means that xpc/ needs to be able to find the generated
Features.inc, wich is also a bit ugly.

clang-tools-extra/clangd/Transport.h
clang-tools-extra/clangd/tool/ClangdMain.cpp
llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn

index b3db4eb..ae6da72 100644 (file)
@@ -18,7 +18,6 @@
 #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_TRANSPORT_H_
 #define LLVM_CLANG_TOOLS_EXTRA_CLANGD_TRANSPORT_H_
 
-#include "Features.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/Support/JSON.h"
 #include "llvm/Support/raw_ostream.h"
index 8db52c6..c03dd92 100644 (file)
@@ -6,11 +6,13 @@
 //
 //===----------------------------------------------------------------------===//
 
+// Must be before Transport.h include.
+#include "Features.h"
+
 #include "ClangdLSPServer.h"
 #include "CodeComplete.h"
 #include "Config.h"
 #include "ConfigProvider.h"
-#include "Features.h"
 #include "PathMapping.h"
 #include "Protocol.h"
 #include "TidyProvider.h"
index 921e0db..0d37539 100644 (file)
@@ -16,7 +16,6 @@ static_library("transport") {
   deps = [
     ":conversions",
     "//clang-tools-extra/clangd",
-    "//clang-tools-extra/clangd:features",
     "//clang-tools-extra/clangd/support",
     "//llvm/lib/Support",
   ]