Disable System.Diagnostics.Tests.EventLogSourceCreationTests (#36138)
authorSantiago Fernandez Madero <safern@microsoft.com>
Wed, 13 May 2020 21:28:55 +0000 (14:28 -0700)
committerGitHub <noreply@github.com>
Wed, 13 May 2020 21:28:55 +0000 (14:28 -0700)
* Disable System.Diagnostics.Tests.EventLogSourceCreationTests.CheckSourceExistenceAndDeletion

* Fix trait to skip tests in CI

* Use ActiveIssue instead

src/libraries/System.Diagnostics.EventLog/tests/EventLogTests/EventLogSourceCreationTests.cs

index 29bfba9..fc2e0f3 100644 (file)
@@ -9,7 +9,7 @@ namespace System.Diagnostics.Tests
 {
     public class EventLogSourceCreationTests
     {
-        [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void CheckSourceExistenceAndDeletion()
         {
@@ -29,7 +29,7 @@ namespace System.Diagnostics.Tests
             Assert.False(EventLog.SourceExists(source));
         }
 
-        [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
         public void LogNameWithSame8FirstChars_NetCore()
@@ -56,7 +56,7 @@ namespace System.Diagnostics.Tests
             }
         }
 
-        [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         [SkipOnTargetFramework(~TargetFrameworkMonikers.NetFramework)]
         public void LogNameWithSame8FirstChars_NetFramework()
@@ -145,7 +145,7 @@ namespace System.Diagnostics.Tests
             Assert.Throws<ArgumentNullException>(() => EventLog.CreateEventSource(null));
         }
 
-        [Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/36135")]
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void SourceAlreadyExistsWhenCreatingSource()
         {