drm/vmwgfx: Fix memory allocation check and a leak of object fifo
authorColin Ian King <colin.king@canonical.com>
Fri, 14 May 2021 14:49:30 +0000 (15:49 +0100)
committerZack Rusin <zackr@vmware.com>
Fri, 14 May 2021 18:38:02 +0000 (14:38 -0400)
The allocation of fifo is lacking an allocation failure check, so
fix this by adding one.

In the case where fifo->static_buffer fails to be allocated the
error return path neglects to kfree the fifo object. Fix this by
adding in the missing kfree.

Kudos to Dan Carpenter for spotting the missing kzalloc failure
check.

Addresses-Coverity: ("Resource leak")
Fixes: 2cd80dbd3551 ("drm/vmwgfx: Add basic support for SVGA3")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Zack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210514144930.89813-1-colin.king@canonical.com
drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c

index 027d7d504e786ff5bbfc438a79b35191ffd3e480..9c89189a226d5fc2598d6854d18028c97552aac6 100644 (file)
@@ -105,10 +105,14 @@ struct vmw_fifo_state *vmw_fifo_create(struct vmw_private *dev_priv)
                return NULL;
 
        fifo = kzalloc(sizeof(*fifo), GFP_KERNEL);
+       if (!fifo)
+               return ERR_PTR(-ENOMEM);
        fifo->static_buffer_size = VMWGFX_FIFO_STATIC_SIZE;
        fifo->static_buffer = vmalloc(fifo->static_buffer_size);
-       if (unlikely(fifo->static_buffer == NULL))
+       if (unlikely(fifo->static_buffer == NULL)) {
+               kfree(fifo);
                return ERR_PTR(-ENOMEM);
+       }
 
        fifo->dynamic_buffer = NULL;
        fifo->reserved_size = 0;