PCI: imx6: Mark PHY functions as i.MX6 specific
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Sat, 2 Feb 2019 00:15:21 +0000 (16:15 -0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 4 Feb 2019 11:52:47 +0000 (11:52 +0000)
PCIe PHY IP block on i.MX7D differs from the one used on i.MX6 family,
so none of the code in the current implementation of
imx6_setup_phy_mpll() or imx6_pcie_reset_phy() is applicable.

Introduce IMX6_PCIE_FLAG_IMX6_PHY and check for it in the aforementioned
functions to make sure they are only executed on appropriate PCIe IP
variants.

Tested-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
[lorenzo.pieralisi@arm.com: updated log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Leonard Crestez <leonard.crestez@nxp.com>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>
Cc: Richard Zhu <hongxing.zhu@nxp.com>
drivers/pci/controller/dwc/pci-imx6.c

index 1e940ba..26e1e97 100644 (file)
@@ -41,8 +41,11 @@ enum imx6_pcie_variants {
        IMX7D,
 };
 
+#define IMX6_PCIE_FLAG_IMX6_PHY                        BIT(0)
+
 struct imx6_pcie_drvdata {
        enum imx6_pcie_variants variant;
+       u32 flags;
 };
 
 struct imx6_pcie {
@@ -255,6 +258,9 @@ static void imx6_pcie_reset_phy(struct imx6_pcie *imx6_pcie)
 {
        u32 tmp;
 
+       if (!(imx6_pcie->drvdata->flags & IMX6_PCIE_FLAG_IMX6_PHY))
+               return;
+
        pcie_phy_read(imx6_pcie, PHY_RX_OVRD_IN_LO, &tmp);
        tmp |= (PHY_RX_OVRD_IN_LO_RX_DATA_EN |
                PHY_RX_OVRD_IN_LO_RX_PLL_EN);
@@ -572,6 +578,9 @@ static int imx6_setup_phy_mpll(struct imx6_pcie *imx6_pcie)
        int mult, div;
        u32 val;
 
+       if (!(imx6_pcie->drvdata->flags & IMX6_PCIE_FLAG_IMX6_PHY))
+               return 0;
+
        switch (phy_rate) {
        case 125000000:
                /*
@@ -1090,12 +1099,15 @@ static void imx6_pcie_shutdown(struct platform_device *pdev)
 static const struct imx6_pcie_drvdata drvdata[] = {
        [IMX6Q] = {
                .variant = IMX6Q,
+               .flags = IMX6_PCIE_FLAG_IMX6_PHY,
        },
        [IMX6SX] = {
                .variant = IMX6SX,
+               .flags = IMX6_PCIE_FLAG_IMX6_PHY,
        },
        [IMX6QP] = {
                .variant = IMX6QP,
+               .flags = IMX6_PCIE_FLAG_IMX6_PHY,
        },
        [IMX7D] = {
                .variant = IMX7D,