scsi: libsas: Delete enum sas_phy_type
authorJohn Garry <john.g.garry@oracle.com>
Tue, 15 Aug 2023 11:51:49 +0000 (11:51 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 21 Aug 2023 21:50:57 +0000 (17:50 -0400)
enum sas_phy_type is used for asd_sas_phy.type, which is only ever set, so
delete this member and the enum.

Signed-off-by: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20230815115156.343535-4-john.g.garry@oracle.com
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aic94xx/aic94xx_hwi.c
drivers/scsi/hisi_sas/hisi_sas_main.c
drivers/scsi/isci/phy.c
drivers/scsi/mvsas/mv_init.c
drivers/scsi/pm8001/pm8001_init.c
include/scsi/libsas.h

index d8f56e5..75848de 100644 (file)
@@ -74,7 +74,6 @@ static int asd_init_phy(struct asd_phy *phy)
        sas_phy->enabled = 1;
        sas_phy->iproto = SAS_PROTOCOL_ALL;
        sas_phy->tproto = 0;
-       sas_phy->type = PHY_TYPE_PHYSICAL;
        sas_phy->role = PHY_ROLE_INITIATOR;
        sas_phy->oob_mode = OOB_NOT_CONNECTED;
        sas_phy->linkrate = SAS_LINK_RATE_UNKNOWN;
index 2e69f24..fb596ec 100644 (file)
@@ -1020,7 +1020,6 @@ static void hisi_sas_phy_init(struct hisi_hba *hisi_hba, int phy_no)
        sas_phy->enabled = (phy_no < hisi_hba->n_phy) ? 1 : 0;
        sas_phy->iproto = SAS_PROTOCOL_ALL;
        sas_phy->tproto = 0;
-       sas_phy->type = PHY_TYPE_PHYSICAL;
        sas_phy->role = PHY_ROLE_INITIATOR;
        sas_phy->oob_mode = OOB_NOT_CONNECTED;
        sas_phy->linkrate = SAS_LINK_RATE_UNKNOWN;
index ea2e339..743a3c6 100644 (file)
@@ -1406,7 +1406,6 @@ void isci_phy_init(struct isci_phy *iphy, struct isci_host *ihost, int index)
        iphy->sas_phy.enabled = 1;
        iphy->sas_phy.iproto = SAS_PROTOCOL_ALL;
        iphy->sas_phy.tproto = 0;
-       iphy->sas_phy.type = PHY_TYPE_PHYSICAL;
        iphy->sas_phy.role = PHY_ROLE_INITIATOR;
        iphy->sas_phy.oob_mode = OOB_NOT_CONNECTED;
        iphy->sas_phy.linkrate = SAS_LINK_RATE_UNKNOWN;
index 408113b..d5cf563 100644 (file)
@@ -86,7 +86,6 @@ static void mvs_phy_init(struct mvs_info *mvi, int phy_id)
        sas_phy->enabled = (phy_id < mvi->chip->n_phy) ? 1 : 0;
        sas_phy->iproto = SAS_PROTOCOL_ALL;
        sas_phy->tproto = 0;
-       sas_phy->type = PHY_TYPE_PHYSICAL;
        sas_phy->role = PHY_ROLE_INITIATOR;
        sas_phy->oob_mode = OOB_NOT_CONNECTED;
        sas_phy->linkrate = SAS_LINK_RATE_UNKNOWN;
index e5d794a..0ffde0b 100644 (file)
@@ -164,7 +164,6 @@ static void pm8001_phy_init(struct pm8001_hba_info *pm8001_ha, int phy_id)
        sas_phy->enabled = (phy_id < pm8001_ha->chip->n_phy) ? 1 : 0;
        sas_phy->iproto = SAS_PROTOCOL_ALL;
        sas_phy->tproto = 0;
-       sas_phy->type = PHY_TYPE_PHYSICAL;
        sas_phy->role = PHY_ROLE_INITIATOR;
        sas_phy->oob_mode = OOB_NOT_CONNECTED;
        sas_phy->linkrate = SAS_LINK_RATE_UNKNOWN;
index 3048660..e54bcdc 100644 (file)
@@ -29,11 +29,6 @@ enum sas_phy_role {
        PHY_ROLE_INITIATOR = 0x80,
 };
 
-enum sas_phy_type {
-       PHY_TYPE_PHYSICAL,
-       PHY_TYPE_VIRTUAL
-};
-
 /* The events are mnemonically described in sas_dump.c
  * so when updating/adding events here, please also
  * update the other file too.
@@ -316,7 +311,6 @@ struct asd_sas_phy {
        enum sas_protocol iproto;
        enum sas_protocol tproto;
 
-       enum sas_phy_type  type;
        enum sas_phy_role  role;
        enum sas_oob_mode  oob_mode;
        enum sas_linkrate linkrate;