fsi: sbefifo: Remove limits on user-specified read timeout
authorEddie James <eajames@linux.ibm.com>
Mon, 12 Jun 2023 19:56:49 +0000 (14:56 -0500)
committerJoel Stanley <joel@jms.id.au>
Wed, 9 Aug 2023 06:13:27 +0000 (15:43 +0930)
There's no reason to limit the user here. The way the driver is
designed, extremely large transfers require extremely long timeouts.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/20230612195657.245125-7-eajames@linux.ibm.com
Signed-off-by: Joel Stanley <joel@jms.id.au>
drivers/fsi/fsi-sbefifo.c

index 74e5baf..402e2d2 100644 (file)
@@ -971,17 +971,12 @@ static int sbefifo_read_timeout(struct sbefifo_user *user, void __user *argp)
 
        if (timeout == 0) {
                user->read_timeout_ms = SBEFIFO_TIMEOUT_START_RSP;
-               dev_dbg(dev, "Timeout reset to %d\n", user->read_timeout_ms);
+               dev_dbg(dev, "Timeout reset to %us\n", user->read_timeout_ms / 1000);
                return 0;
        }
 
-       if (timeout < 10 || timeout > 120)
-               return -EINVAL;
-
        user->read_timeout_ms = timeout * 1000; /* user timeout is in sec */
-
-       dev_dbg(dev, "Timeout set to %d\n", user->read_timeout_ms);
-
+       dev_dbg(dev, "Timeout set to %us\n", timeout);
        return 0;
 }