wpesrc: add some debug logging around WPEView creation/destruction
authorMatthew Waters <matthew@centricular.com>
Wed, 7 Oct 2020 10:13:09 +0000 (21:13 +1100)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Tue, 13 Oct 2020 08:48:05 +0000 (08:48 +0000)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1663>

ext/wpe/WPEThreadedView.cpp
ext/wpe/gstwpesrc.cpp

index a4e4d1c976d5e6f845438364420eaf98a7785f8f..bd0ff635931e3d21dfe5d69b87cd6ae9647492fc 100644 (file)
@@ -270,6 +270,8 @@ WPEView::WPEView(WebKitWebContext* web_context, GstWpeSrc* src, GstGLContext* co
 
 WPEView::~WPEView()
 {
+    GST_TRACE ("%p destroying", this);
+
     g_mutex_clear(&threading.ready_mutex);
     g_cond_clear(&threading.ready_cond);
 
@@ -285,10 +287,12 @@ WPEView::~WPEView()
             egl.committed = nullptr;
         }
         if (shm.pending) {
+            GST_TRACE ("%p freeing shm pending %" GST_PTR_FORMAT, this, shm.pending);
             gst_buffer_unref(shm.pending);
             shm.pending = nullptr;
         }
         if (shm.committed) {
+            GST_TRACE ("%p freeing shm commited %" GST_PTR_FORMAT, this, shm.committed);
             gst_buffer_unref(shm.committed);
             shm.committed = nullptr;
         }
@@ -316,6 +320,7 @@ WPEView::~WPEView()
     }
 
     g_mutex_clear(&images_mutex);
+    GST_TRACE ("%p destroyed", this);
 }
 
 void WPEView::notifyLoadFinished()
index 1481ebb21b3b9341af223461e54918ac3700f618..18c95abcdfb6bf3f5ec3b8383a9ec9d39fed2cc6 100644 (file)
@@ -252,7 +252,7 @@ gst_wpe_src_start (GstWpeSrc * src)
     display = base_src->display;
   }
 
-  GST_DEBUG_OBJECT (src, "Will fill GLMemories: %d\n", src->gl_enabled);
+  GST_DEBUG_OBJECT (src, "Will %sfill GLMemories", src->gl_enabled ? "" : "NOT ");
 
   auto & thread = WPEContextThread::singleton ();
 
@@ -261,6 +261,7 @@ gst_wpe_src_start (GstWpeSrc * src)
         GST_VIDEO_INFO_WIDTH (&base_src->out_info),
         GST_VIDEO_INFO_HEIGHT (&base_src->out_info));
     created_view = TRUE;
+    GST_DEBUG_OBJECT (src, "created view %p", src->view);
   }
 
   if (!src->view) {
@@ -317,6 +318,7 @@ static void
 gst_wpe_src_stop_unlocked (GstWpeSrc * src)
 {
   if (src->view) {
+    GST_DEBUG_OBJECT (src, "deleting view %p", src->view);
     delete src->view;
     src->view = NULL;
   }