staging: r8188eu: remove _dbg_dump_tx_info function

Remove _dbg_dump_tx_info from hal/rtl8188e_xmit.c as it is just a
dumping function that contains a lot of unclear DBG_88E calls, and has
no other external effect, other than calling a function that ultimately
determines whether or not to dump/trigger the DBG_88E calls. Also remove
its declaration and single call site.

Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210818234253.208271-2-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/hal/rtl8188e_xmit.c b/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
index 164ec66..d2b55d5 100644 (file)
--- a/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
@@ -42,34 +42,3 @@ void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf)
                                        RTW_SCTX_DONE_CCX_PKT_FAIL);
        }
 }
-
-void _dbg_dump_tx_info(struct adapter *padapter, int frame_tag,
-                      struct tx_desc *ptxdesc)
-{
-       u8 dmp_txpkt;
-       bool dump_txdesc = false;
-       rtw_hal_get_def_var(padapter, HAL_DEF_DBG_DUMP_TXPKT, &(dmp_txpkt));
-
-       if (dmp_txpkt == 1) {/* dump txdesc for data frame */
-               DBG_88E("dump tx_desc for data frame\n");
-               if ((frame_tag & 0x0f) == DATA_FRAMETAG)
-                       dump_txdesc = true;
-       } else if (dmp_txpkt == 2) {/* dump txdesc for mgnt frame */
-               DBG_88E("dump tx_desc for mgnt frame\n");
-               if ((frame_tag & 0x0f) == MGNT_FRAMETAG)
-                       dump_txdesc = true;
-       }
-
-       if (dump_txdesc) {
-               DBG_88E("=====================================\n");
-               DBG_88E("txdw0(0x%08x)\n", ptxdesc->txdw0);
-               DBG_88E("txdw1(0x%08x)\n", ptxdesc->txdw1);
-               DBG_88E("txdw2(0x%08x)\n", ptxdesc->txdw2);
-               DBG_88E("txdw3(0x%08x)\n", ptxdesc->txdw3);
-               DBG_88E("txdw4(0x%08x)\n", ptxdesc->txdw4);
-               DBG_88E("txdw5(0x%08x)\n", ptxdesc->txdw5);
-               DBG_88E("txdw6(0x%08x)\n", ptxdesc->txdw6);
-               DBG_88E("txdw7(0x%08x)\n", ptxdesc->txdw7);
-               DBG_88E("=====================================\n");
-       }
-}

diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
index 50c4b93..b279309 100644 (file)
--- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
+++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
@@ -330,7 +330,6 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag
        ODM_SetTxAntByTxInfo_88E(&haldata->odmpriv, pmem, pattrib->mac_id);
 
        rtl8188eu_cal_txdesc_chksum(ptxdesc);
-       _dbg_dump_tx_info(adapt, pxmitframe->frame_tag, ptxdesc);
        return pull;
 }
 

diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
index ff8b734..d2099da 100644 (file)
--- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
@@ -153,7 +153,4 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *padapter,
 void dump_txrpt_ccx_88e(void *buf);
 void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf);
 
-void _dbg_dump_tx_info(struct adapter *padapter, int frame_tag,
-                      struct tx_desc *ptxdesc);
-
 #endif /* __RTL8188E_XMIT_H__ */