iio: temperature: ltc2983: allocate iio channels once

commit 4132f19173211856d35180958d2754f5c56d520a upstream.

Currently, every time the device wakes up from sleep, the
iio_chan array is reallocated, leaking the previous one
until the device is removed (basically never).

Move the allocation to the probe function to avoid this.

Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
Fixes: f110f3188e563 ("iio: temperature: Add support for LTC2983")
Cc: <Stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20221014123724.1401011-2-demonsingur@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
index 3b4a0e60e6059481b7e3ea3c4ea79908a48ed6d8..8306daa7790812e53602ca1cf6a75d0a97efabef 100644 (file)
--- a/drivers/iio/temperature/ltc2983.c
+++ b/drivers/iio/temperature/ltc2983.c
@@ -1376,13 +1376,6 @@ static int ltc2983_setup(struct ltc2983_data *st, bool assign_iio)
                return ret;
        }
 
-       st->iio_chan = devm_kzalloc(&st->spi->dev,
-                                   st->iio_channels * sizeof(*st->iio_chan),
-                                   GFP_KERNEL);
-
-       if (!st->iio_chan)
-               return -ENOMEM;
-
        ret = regmap_update_bits(st->regmap, LTC2983_GLOBAL_CONFIG_REG,
                                 LTC2983_NOTCH_FREQ_MASK,
                                 LTC2983_NOTCH_FREQ(st->filter_notch_freq));
@@ -1494,6 +1487,12 @@ static int ltc2983_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
+       st->iio_chan = devm_kzalloc(&spi->dev,
+                                   st->iio_channels * sizeof(*st->iio_chan),
+                                   GFP_KERNEL);
+       if (!st->iio_chan)
+               return -ENOMEM;
+
        ret = ltc2983_setup(st, true);
        if (ret)
                return ret;