imapx_get_filename() should be static.

No idea why this function was made public.  It's just a class method
implementation and can be invoked through camel_folder_get_filename().

Not going to bump the libcamel soname over this.  Nothing external is
using it.

diff --git a/camel/camel-imapx-folder.c b/camel/camel-imapx-folder.c
index 965dcfd..a9e3a56 100644 (file)
--- a/camel/camel-imapx-folder.c
+++ b/camel/camel-imapx-folder.c
@@ -222,16 +222,6 @@ imapx_folder_finalize (GObject *object)
        G_OBJECT_CLASS (camel_imapx_folder_parent_class)->finalize (object);
 }
 
-gchar *
-imapx_get_filename (CamelFolder *folder,
-                    const gchar *uid,
-                    GError **error)
-{
-       CamelIMAPXFolder *ifolder = (CamelIMAPXFolder *) folder;
-
-       return camel_data_cache_get_filename (ifolder->cache, "cache", uid);
-}
-
 /* Algorithm for selecting a folder:
  *
  *  - If uidvalidity == old uidvalidity
@@ -364,6 +354,16 @@ imapx_search_by_expression (CamelFolder *folder,
        return matches;
 }
 
+static gchar *
+imapx_get_filename (CamelFolder *folder,
+                    const gchar *uid,
+                    GError **error)
+{
+       CamelIMAPXFolder *ifolder = (CamelIMAPXFolder *) folder;
+
+       return camel_data_cache_get_filename (ifolder->cache, "cache", uid);
+}
+
 static gboolean
 imapx_append_message_sync (CamelFolder *folder,
                            CamelMimeMessage *message,

diff --git a/camel/camel-imapx-folder.h b/camel/camel-imapx-folder.h
index f96f561..ab26a9e 100644 (file)
--- a/camel/camel-imapx-folder.h
+++ b/camel/camel-imapx-folder.h
@@ -90,9 +90,6 @@ CamelFolder * camel_imapx_folder_new          (CamelStore *parent,
                                                 const gchar *path,
                                                 const gchar *raw,
                                                 GError **error);
-gchar *                imapx_get_filename              (CamelFolder *folder,
-                                                const gchar *uid,
-                                                GError **error);
 gchar **       camel_imapx_folder_dup_quota_root_names
                                                (CamelIMAPXFolder *folder);
 void           camel_imapx_folder_set_quota_root_names

diff --git a/docs/reference/camel/camel-sections.txt b/docs/reference/camel/camel-sections.txt
index 09ed1b3..edd5427 100644 (file)
--- a/docs/reference/camel/camel-sections.txt
+++ b/docs/reference/camel/camel-sections.txt
@@ -809,7 +809,6 @@ CamelIMAPXFolderClass
 <SUBSECTION Private>
 CamelIMAPXFolderPrivate
 camel_imapx_folder_get_type
-imapx_get_filename
 </SECTION>
 
 <SECTION>