clk: imx8m: Suppress bind attrs

The clock drivers on imx8m series are registered as platform devices and
this opens the possibility of reloading the driver at runtime.

This doesn't actually work: clocks are never removed and attempting to
bind again results in registration errors and a crash. Almost all
devices depend on clocks anyway so rebinding is unlikely to ever be
useful

Fix this by explicitly suppressing bind attrs like several other
clock drivers.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>

diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index 9246e89..d5e767e 100644 (file)
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -621,6 +621,11 @@ static struct platform_driver imx8mm_clk_driver = {
        .probe = imx8mm_clocks_probe,
        .driver = {
                .name = "imx8mm-ccm",
+               /*
+                * Disable bind attributes: clocks are not removed and
+                * reloading the driver will crash or break devices.
+                */
+               .suppress_bind_attrs = true,
                .of_match_table = of_match_ptr(imx8mm_clk_of_match),
        },
 };

diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index 4749bea..b0e0778 100644 (file)
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -578,6 +578,11 @@ static struct platform_driver imx8mn_clk_driver = {
        .probe = imx8mn_clocks_probe,
        .driver = {
                .name = "imx8mn-ccm",
+               /*
+                * Disable bind attributes: clocks are not removed and
+                * reloading the driver will crash or break devices.
+                */
+               .suppress_bind_attrs = true,
                .of_match_table = of_match_ptr(imx8mn_clk_of_match),
        },
 };

diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
index c8ab86f..14a1483 100644 (file)
--- a/drivers/clk/imx/clk-imx8mq.c
+++ b/drivers/clk/imx/clk-imx8mq.c
@@ -613,6 +613,11 @@ static struct platform_driver imx8mq_clk_driver = {
        .probe = imx8mq_clocks_probe,
        .driver = {
                .name = "imx8mq-ccm",
+               /*
+                * Disable bind attributes: clocks are not removed and
+                * reloading the driver will crash or break devices.
+                */
+               .suppress_bind_attrs = true,
                .of_match_table = of_match_ptr(imx8mq_clk_of_match),
        },
 };