dns: verify argument is valid function in resolve

Don't use argument as callback if it's not a valid callback function.
Throw a valid exception instead explaining the issue. Adds to #7070
("DNS — Throw meaningful error(s)").

diff --git a/lib/dns.js b/lib/dns.js
index 15ee6a436255f0e7c01ca081ed604c7ec0ae4462..dcf2128e287034e1a995dcd25311c69825d3a6da 100644 (file)
--- a/lib/dns.js
+++ b/lib/dns.js
@@ -184,9 +184,11 @@ exports.resolve = function(domain, type_, callback_) {
   if (typeof type_ == 'string') {
     resolver = resolveMap[type_];
     callback = callback_;
-  } else {
+  } else if (util.isFunction(type_)) {
     resolver = exports.resolve4;
     callback = type_;
+  } else {
+    throw new Error('Type must be a string')
   }
 
   if (typeof resolver === 'function') {