test/dbus-daemon: Fix some memory leaks
authorSimon McVittie <smcv@collabora.com>
Fri, 2 Jun 2017 11:19:18 +0000 (12:19 +0100)
committerSimon McVittie <smcv@collabora.com>
Thu, 8 Jun 2017 15:58:40 +0000 (16:58 +0100)
Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=101257

test/dbus-daemon.c

index d0b44d7..9f9dd72 100644 (file)
@@ -370,6 +370,8 @@ test_no_reply (Fixture *f,
   else
     g_assert_cmpstr (f->e.message, ==,
         "Message did not receive a reply (timeout by message bus)");
+
+  dbus_message_unref (reply);
 }
 
 static void
@@ -529,6 +531,9 @@ test_creds (Fixture *f,
 #ifdef G_OS_WIN32
   g_assert (seen & SEEN_WINDOWS_SID);
 #endif
+
+  dbus_message_unref (m);
+  dbus_pending_call_unref (pc);
 }
 
 static void
@@ -599,6 +604,9 @@ test_processid (Fixture *f,
     {
       g_error ("Unexpected error: %s: %s", error.name, error.message);
     }
+
+  dbus_message_unref (m);
+  dbus_pending_call_unref (pc);
 }
 
 static void
@@ -644,6 +652,8 @@ test_canonical_path_uae (Fixture *f,
       DBUS_MESSAGE_TYPE_METHOD_RETURN);
 
   dbus_message_unref (m);
+  dbus_pending_call_unref (pc);
+  pc = NULL;
 
   /* Now try with the wrong object path */
   m = dbus_message_new_method_call (DBUS_SERVICE_DBUS,
@@ -684,6 +694,7 @@ test_canonical_path_uae (Fixture *f,
   g_assert_cmpstr (dbus_message_get_signature (m), ==, "s");
 
   dbus_message_unref (m);
+  dbus_pending_call_unref (pc);
 }
 
 static void
@@ -815,6 +826,7 @@ test_max_replies_per_connection (Fixture *f,
         g_error ("OOM");
 
       dbus_message_unref (reply);
+      dbus_message_unref (m);
     }
 
   /* Wait for all 5 replies to come in. */