dma-buf: Move code out of mutex-protected section in dma_buf_attach()
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Thu, 26 Jan 2012 11:27:25 +0000 (12:27 +0100)
committerSumit Semwal <sumit.semwal@ti.com>
Mon, 19 Mar 2012 10:12:15 +0000 (15:42 +0530)
Some fields can be set without mutex protection. Initialize them before
locking the mutex.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
drivers/base/dma-buf.c

index 97450a5..8afe2dd 100644 (file)
@@ -192,10 +192,11 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
        if (attach == NULL)
                return ERR_PTR(-ENOMEM);
 
-       mutex_lock(&dmabuf->lock);
-
        attach->dev = dev;
        attach->dmabuf = dmabuf;
+
+       mutex_lock(&dmabuf->lock);
+
        if (dmabuf->ops->attach) {
                ret = dmabuf->ops->attach(dmabuf, dev, attach);
                if (ret)