* stdlib/setenv.c (__add_to_environ):

Dump core quickly if setenv (..., NULL, ...) is called.

diff --git a/ChangeLog b/ChangeLog
index fb1591f15eed573fff82c40f68346bd86ae4a2d5..3b1255227526ebe33506738345095a315ac564e5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-03-13  Paul Eggert  <eggert@cs.ucla.edu>
+
+       * stdlib/setenv.c (__add_to_environ):
+       Dump core quickly if setenv (..., NULL, ...) is called.
+
 2015-03-13  Roland McGrath  <roland@hack.frob.com>
 
        * sysdeps/arm/tls-macros.h: Include <sysdep.h>.

diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index b60c4f0151a623669b5cdb738528cac4e0a15643..05342367b1b1a54a1b59381e2644cefc4b415748 100644 (file)
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -114,8 +114,16 @@ __add_to_environ (name, value, combined, replace)
 {
   char **ep;
   size_t size;
+
+  /* Compute lengths before locking, so that the critical section is
+     less of a performance bottleneck.  VALLEN is needed only if
+     COMBINED is non-null.  Also, testing COMBINED instead of VALUE
+     causes setenv (..., NULL, ...) to dump core now instead of
+     corrupting memory later.  */
   const size_t namelen = strlen (name);
-  const size_t vallen = value != NULL ? strlen (value) + 1 : 0;
+  size_t vallen;
+  if (combined != NULL)
+    vallen = strlen (value) + 1;
 
   LOCK;