Fix dmabuf memory leak 04/298104/1
authorPaweł Stawicki <p.stawicki@samsung.com>
Wed, 30 Aug 2023 15:18:17 +0000 (17:18 +0200)
committerPaweł Stawicki <p.stawicki@samsung.com>
Thu, 31 Aug 2023 14:25:45 +0000 (16:25 +0200)
Change-Id: Iaff9d750fd00181ca5f86015b36c562d72a4e6b5

src/esplusplayer/include_internal/esplayer/decoded_pkt_list.h

index 843ae1c..59ae836 100644 (file)
 
 namespace {
 void DecodedPacketDeleter(esplusplayer_decoded_video_packet* packet) {
-  if (packet == nullptr || packet->surface_data == nullptr) return;
+  if (packet == nullptr) return;
   // LOG_DEBUG("packet[%p] deleted", packet);
   if(packet->private_data) { // hw dec
     gst_buffer_unref((GstBuffer *)packet->private_data);
     packet->private_data = nullptr;
-  } else {
+  }
+  if(packet->surface_data) {
     tbm_surface_destroy(static_cast<tbm_surface_h>(packet->surface_data));
-    packet->surface_data = NULL;
+    packet->surface_data = nullptr;
   }
 }
 }  // namespace