projects
/
platform
/
upstream
/
gst-plugins-base.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5e37393
)
playbin: Don't ref_sink() the sinks twice
author
shakin chou
<shakin@outlook.com>
Fri, 3 Nov 2017 03:39:54 +0000
(11:39 +0800)
committer
Sebastian Dröge
<sebastian@centricular.com>
Tue, 7 Nov 2017 08:32:34 +0000
(10:32 +0200)
Since we're already sunk floating reference, we shouldn't call ref_sink
again, which increases the ref_count and cause leaks.
https://bugzilla.gnome.org/show_bug.cgi?id=789547
gst/playback/gstplaybin2.c
patch
|
blob
|
history
diff --git
a/gst/playback/gstplaybin2.c
b/gst/playback/gstplaybin2.c
index
46da78e
..
a2e9ed4
100644
(file)
--- a/
gst/playback/gstplaybin2.c
+++ b/
gst/playback/gstplaybin2.c
@@
-4663,7
+4663,6
@@
autoplug_select_cb (GstElement * decodebin, GstPad * pad,
gst_plugin_feature_get_name (GST_PLUGIN_FEATURE (ave->sink)));
continue;
}
- gst_object_ref_sink (*sinkp);
created_sink = TRUE;
}
}