[lldb][NFC] Address some review feedback for D80775 ('command script delete' completion)
authorRaphael Isemann <teemperor@gmail.com>
Thu, 4 Jun 2020 08:27:03 +0000 (10:27 +0200)
committerRaphael Isemann <teemperor@gmail.com>
Thu, 4 Jun 2020 08:30:27 +0000 (10:30 +0200)
In the similar review D81128, Jonas pointed out some style errors that also
apply to D80775 (which is already committed). Also applying the changes
suggested there to this code.

lldb/source/Commands/CommandObjectCommands.cpp

index 8f72ed7..8c78803 100644 (file)
@@ -1770,14 +1770,11 @@ public:
   void
   HandleArgumentCompletion(CompletionRequest &request,
                            OptionElementVector &opt_element_vector) override {
-
     if (!m_interpreter.HasCommands() || request.GetCursorIndex() != 0)
       return;
-    const auto &user_dict = m_interpreter.GetUserCommands();
 
-    for (auto pos = user_dict.begin(); pos != user_dict.end(); ++pos) {
-      request.TryCompleteCurrentArg(pos->first, pos->second->GetHelp());
-    }
+    for (const auto &c : m_interpreter.GetUserCommands())
+      request.TryCompleteCurrentArg(c.first, c.second->GetHelp());
   }
 
 protected: