va: Fix error handling for base transform
authorMengkejiergeli Ba <mengkejiergeli.ba@intel.com>
Tue, 12 Oct 2021 09:44:27 +0000 (17:44 +0800)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Thu, 14 Oct 2021 11:12:41 +0000 (11:12 +0000)
Need to check the returned value of gst_buffer_pool_set_active() when
setting the active status of buffer pool.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131>

subprojects/gst-plugins-bad/sys/va/gstvabasetransform.c

index 13bad4e..eff18cb 100644 (file)
@@ -729,7 +729,11 @@ _get_sinkpad_pool (GstVaBaseTransform * self)
 
   gst_object_unref (allocator);
 
-  gst_buffer_pool_set_active (self->priv->sinkpad_pool, TRUE);
+  if (!gst_buffer_pool_set_active (self->priv->sinkpad_pool, TRUE)) {
+    GST_WARNING_OBJECT (self, "failed to active the sinkpad pool %"
+        GST_PTR_FORMAT, self->priv->sinkpad_pool);
+    return NULL;
+  }
 
   return self->priv->sinkpad_pool;
 }